BUGFIX: clarify Hosted field style info banner to mention Custom form requirement - #328
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the translation string for 'hostedFieldInfo' in the SettingsTranslationService to provide a more detailed explanation of when specific styles apply, particularly concerning the 'Custom form' setting and Saferpay-hosted pages. The review feedback suggests a phrasing improvement to the new text to resolve grammatical ambiguity regarding how saved cards are referenced.
| 'enterConfigName' => $this->module->l('Enter configuration name', self::FILE_NAME), | ||
| 'configNameDescription' => html_entity_decode($this->module->l('Name of the Payment Page Configuration created in Saferpay Backoffice (Settings > Payment Page Configuration). Max 20 characters. Allowed: letters, numbers, dots, colons, hyphens, underscores.', self::FILE_NAME), ENT_QUOTES, 'UTF-8'), | ||
| 'hostedFieldInfo' => $this->module->l('Choose which hosted field will be displayed on payment option selection with supported payment methods.', self::FILE_NAME), | ||
| 'hostedFieldInfo' => html_entity_decode($this->module->l('This style applies only to payment methods with "Custom form" enabled in the Payment Methods list. Methods without Custom form or paid with saved cards use the Saferpay-hosted payment page, whose appearance is controlled by "Payment Page configurations name".', self::FILE_NAME), ENT_QUOTES, 'UTF-8'), |
There was a problem hiding this comment.
The phrase "Methods ... paid with saved cards" is slightly ambiguous and grammatically awkward, as payment methods themselves are not "paid". It would be clearer to refer to "payments made with saved cards" or "transactions using saved cards" to distinguish between the configuration of the method and the state of the transaction.
'hostedFieldInfo' => html_entity_decode($this->module->l('This style applies only to payment methods with "Custom form" enabled in the Payment Methods list. Methods without Custom form or payments made with saved cards use the Saferpay-hosted payment page, whose appearance is controlled by "Payment Page configurations name".', self::FILE_NAME), ENT_QUOTES, 'UTF-8'),
bfab294
into
SL-346/accessibility-eaa-compliance
1 participant
Summary
ConfigSet).Changes
src/Service/SettingsTranslationService.php: rewritehostedFieldInfoto explicitly state the Custom form prerequisite and point users to "Payment Page configurations name" for the Saferpay-hosted page styling. Wrapped inhtml_entity_decode(..., ENT_QUOTES, 'UTF-8')so quotes render correctly (same pattern already used forconfigNameDescription).No FE/build changes — same translation key, same banner component.
Test plan
").