SL-380: Fix infinite spinner on fail

[justelis22]

Self-Checks

• I have performed a self-review of my code.
• I have updated/added necessary technical documentation in the README file.

JIRA task link

Summary

QA Checklist Labels

• Bug fix?
• New feature?
• Improvement?
• Technical debt?
• Reusable?
• Covered by tests?

QA Checklist

Additional Context

Frontend Changes

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[Copilot]

Pull request overview

Updates the SaferPay fail front controller to proactively transition existing “pre-authorization” orders into a failed/canceled state, preventing the checkout status poller from spinning indefinitely after a rejected authorization.

Changes:

• Adds markOrderAsFailed() call during initContent() to update PrestaShop order state and SaferPay order flags on failure.
• Introduces logic to avoid overriding successful authorizations/captures while ensuring failed attempts don’t remain “awaiting payment”.

Comments suppressed due to low confidence (1)

controllers/front/fail.php:173

• SaferPayOrder flags are only normalized when canceled is false. If another flow already set canceled = 1 without clearing pending (e.g. failValidation.php), this method will skip clearing pending/authorized, leaving inconsistent state in the DB. Consider normalizing the flags when the record is still marked pending.

        if (!$saferPayOrder->canceled) {
            $saferPayOrder->authorized = false;
            $saferPayOrder->pending = false;
            $saferPayOrder->canceled = true;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.