INTERNAL Set redesign release version to 2.1.0 - #340
Merged
Conversation
Nothing 2.1.x was ever released (last tag is v2.0.3), so the redesign ships as 2.1.0. The branch carried 2.1.1 only because an earlier commit bumped 2.0.2 straight to 2.1.1. Folds upgrade/install-2.1.1.php into upgrade/install-2.1.0.php. PS only runs an upgrade file when its version is <= the module version, so at 2.1.0 the 2.1.1 script would never run and the removed AdminSaferPayOfficialFields tab would survive on every upgraded shop.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Checks
JIRA task link
No ticket - internal release housekeeping under epic SL-350.
Summary
The redesign was carrying version 2.1.1, but nothing 2.1.x has ever been released (last tag is v2.0.3, 2026-06-25). The branch only had 2.1.1 because commit 64baef3 bumped 2.0.2 straight to 2.1.1. This sets the release to 2.1.0.
QA Checklist Labels
QA Checklist
Related: #330 (React bundle built in CI), #339 (Composer advisory release-build fix). Both are prerequisites for shipping this version.
Additional Context
Four changes:
saferpayofficial.php-$this->version2.1.1 -> 2.1.0changelog.md-## [2.1.1]->## [2.1.0]. This also closes the gap where the changelog had a 2.1.1 section but no 2.1.0 despiteupgrade/install-2.1.0.phpexisting.upgrade/install-2.1.1.php- deletedupgrade/install-2.1.0.php- now removes both theAdminSaferPayOfficialPaymentandAdminSaferPayOfficialFieldstabsFolding the upgrade script in is required, not tidying. PrestaShop only runs an upgrade file when
file_version <= module_version(classes/module/Module.php:842). At version 2.1.0 theinstall-2.1.1.phpscript would be skipped entirely, so every merchant upgrading from 2.0.3 would keep a dead "Saferpay Fields" admin tab pointing at a controller this redesign deleted.Verified on PrestaShop 9.1.4 / PHP 8.4. Seeded a pre-2.1.0 state using PrestaShop objects (created the legacy Fields tab, set the registered version to 2.0.3), then ran the real
prestashop:module upgrade saferpayofficial:No other version references need touching.
config.xmlis gitignored, untracked, and absent from the release ZIP (PrestaShop regenerates it on install).views/js/admin/settings-app/package.jsonsits at 1.0.0 and is stripped before packaging. The remaining2.1.1matches in the repo are unrelated npm packages and PrestaShop core module versions inside test seed SQL.Noticed while in here, pre-existing and deliberately not changed:
src/Install/AbstractInstaller.php:61still creates the hiddenAdminSaferPayOfficialPaymenttab on a fresh install (its controller is now only a redirect stub to Settings), while this upgrade deletes that tab. Fresh and upgraded shops therefore diverge on it. Happy to make it consistent in a follow-up if wanted.Frontend Changes
None.