fix: export MidiPairingInfoRemovedException#162
Merged
Conversation
The type was added to the platform interface in commit 3c28f4e and is thrown from the BLE transport's pairing stage, but it was left out of the main package's export list, so apps depending only on flutter_midi_command cannot catch it by name and must fall back to the base MidiConnectionException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#161 introduced
MidiPairingInfoRemovedException, thrown from the BLE transport when iOS reportsCBErrorPeerRemovedPairingInformation, but the new type wasn't added toflutter_midi_command's export list. Apps depending only on the main package can't catch it by name, even though this is the exact case where an app wants to show specific guidance ("forget the device in Bluetooth settings, then reconnect"). Instead, they have to fall back to matching the baseMidiConnectionException.This adds the type to the existing
showcombinator.Found while adopting the typed exception hierarchy in an app that migrated from 1.0.2 to 1.0.6. Thanks for the staged-connect and teardown work in #161, it let us delete a pile of downstream defensive code.