[Core]: webp support images #37

Activity

1. spacecabbie

   self-assigned this

   on Jul 15, 2025
2. nielsdrost7

   added a parent issue on Jul 15, 2025

   • [Core]: Epic — Module Core #3
3. nielsdrost7

   added this to the v2.0.0-alpha milestone on Dec 28, 2025
4. InvoicePlane

   deleted a comment from coderabbitai on Jul 15, 2026
5. nielsdrost7

   added

   refinedRefined with SMART plan / test suggestionsRefined with SMART plan / test suggestions

   on Jul 16, 2026
6. nielsdrost7 commented on Jul 16, 2026

   

   nielsdrost7

   on Jul 16, 2026

   Collaborator

   More actions

   ---

   Test Suggestions

   Added to support future implementation of this request. The issue body is unchanged.

   Very few image-upload surfaces exist to test this against today: a repo-wide search finds only two FileUpload::make(...)->image() fields, both for company branding — settings.login_logo and settings.invoice_logo in Modules/Core/Filament/Admin/Pages/Settings.php — with no explicit ->acceptedFileTypes() override, so they rely on Filament/Laravel's default image validation rule (which does accept webp in current Laravel versions). The issue's other examples — product images, client logos, user avatars — don't exist as upload fields anywhere in the codebase yet: Modules\Products\Filament\Company\Resources\Products\Schemas has no FileUpload/image field at all (product images are explicitly out of scope per the Products epic, #8), and there is no client-logo or user-avatar upload field either (see #399 for the related avatar gap). So this request is really "confirm webp works on the two existing logo fields" plus "add image upload, with webp support, to surfaces that don't have image upload at all yet."

   • PHPUnit: it_accepts_a_webp_file_for_the_invoice_logo_setting()

   #[Test]
   public function it_accepts_a_webp_file_for_the_invoice_logo_setting(): void
   {
       /* Arrange */
       Storage::fake('public');
       $file = UploadedFile::fake()->image('logo.webp');
   
       /* Act */
       $component = Livewire::actingAs($this->superAdmin())
           ->test(Settings::class)
           ->fillForm(['settings.invoice_logo' => $file])
           ->call('save');
   
       /* Assert */
       $component->assertHasNoFormErrors();
   }

   • PHPUnit: it_stores_the_webp_file_without_converting_it_to_another_format()

   #[Test]
   public function it_stores_the_webp_file_without_converting_it_to_another_format(): void
   {
       /* Arrange */
       Storage::fake('public');
       $file = UploadedFile::fake()->image('logo.webp');
   
       /* Act */
       Livewire::actingAs($this->superAdmin())
           ->test(Settings::class)
           ->fillForm(['settings.invoice_logo' => $file])
           ->call('save');
   
       /* Assert */
       $stored = Setting::query()->where('setting_key', 'invoice_logo')->value('setting_value');
       $this->assertStringEndsWith('.webp', $stored);
   }

   • PHPUnit: it_rejects_a_webp_file_that_exceeds_the_configured_size_limit()

   #[Test]
   public function it_rejects_a_webp_file_that_exceeds_the_configured_size_limit(): void
   {
       /* Arrange */
       Storage::fake('public');
       $file = UploadedFile::fake()->image('huge.webp')->size(20000);
   
       /* Act */
       $component = Livewire::actingAs($this->superAdmin())
           ->test(Settings::class)
           ->fillForm(['settings.invoice_logo' => $file])
           ->call('save');
   
       /* Assert */
       $component->assertHasFormErrors(['settings.invoice_logo']);
   }

   Edge cases worth covering: this issue's own success criteria (25% page-load reduction, thumbnail/resize handling) assume image-processing infrastructure — thumbnail generation for uploaded images — that doesn't exist anywhere in the codebase today, so that part is a separate, larger effort from "accept webp on upload."; and product images specifically remain unimplemented (no upload field exists at all), so webp support for them can't be built until the base feature (#8, product images) lands.