Fix/theme explorer voting docker#447
Open
Mosas2000 wants to merge 7 commits into
Open
Conversation
…vent utils and badge tests
|
@Mosas2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
…s, fix import orders
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— feat(voting): add aria-labels and focus-visible rings to vote buttons (a11y) on VotingComponent.tsx by adding descriptive aria-label tags ("Approve campaign", "Reject campaign") to both vote buttons and a distinct visible focus state utilizing focus-visible ring classes.
— fix(theme): prevent dark-mode hydration flash and mismatch (hydration flash) by re-architecting ThemeProvider.tsx to synchronously initialize state from local storage during the first client-side render and updating the document's class inside a synchronous useSafeLayoutEffect before paint. Cleaned up the theme switch element in Navbar.tsx with mounting state wrappers to fully guard against hydration mismatches.
7c6e316 — test(explorer): assert testnet and mainnet explorer URL generation (centralised explorer base URLs) by adding src/tests/unit/explorer.test.ts to assert that the active network passphrase correctly determines the Stellar Expert routing.
— test(voting): cover accessible labels and keyboard focus traversal Added full accessibility coverage at src/tests/components/VotingComponent.test.tsx to verify focus traversal, key actions, and accessible names.
— fix(test): configure jest to ignore E2E tests, restore contribution event utils and badge tests Cleaned up pre-existing test suite errors (excluding E2E files from Jest, restoring deleted contribution utility methods, and adjusting status badge assertions).
Closes #291
Closes #294
Closes #288
Closes #295