Skip to content

Fixes#397

Merged
benfoster-dev merged 5 commits into
Iris-IV:mainfrom
JSE19:main
May 29, 2026
Merged

Fixes#397
benfoster-dev merged 5 commits into
Iris-IV:mainfrom
JSE19:main

Conversation

@JSE19
Copy link
Copy Markdown
Contributor

@JSE19 JSE19 commented May 29, 2026

📌 Description

This PR fixes a bug in the voting verification flow where admin_verify() and verify_with_votes() could mark a campaign as verified even if it was cancelled or inactive. The change adds an explicit CampaignNotActive guard before flipping is_verified, preventing invalid verification state transitions.

🔗 Related Issues

Closes #160
Closes #161
Closes #162
Closes #163

🧪 Changes Made

  • Bug fix
  • New feature
  • Refactor
  • Documentation update

✅ Checklist

  • Code compiles successfully
  • Tests added/updated and passing
  • Linting passes (no warnings/errors)
  • Documentation updated (if required)
  • No breaking changes

⚠️ Breaking Changes

None.

📸 Screenshots (if applicable)

N/A

🧩 Additional Notes

  • Only voting.rs and test_voting_verify.rs were changed.
  • Added regression tests for:
    • admin_verify on a cancelled campaign
    • verify_with_votes on a cancelled campaign
  • Verified with the voting verification test suite (cargo test test_voting_verify -- --nocapture).

@sshdopey
Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 29, 2026

@JSE19 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sshdopey
Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@benfoster-dev benfoster-dev merged commit 42340b3 into Iris-IV:main May 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment