Fixes#397
Merged
Merged
Conversation
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
|
@JSE19 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
This PR fixes a bug in the voting verification flow where
admin_verify()andverify_with_votes()could mark a campaign as verified even if it was cancelled or inactive. The change adds an explicitCampaignNotActiveguard before flippingis_verified, preventing invalid verification state transitions.🔗 Related Issues
Closes #160
Closes #161
Closes #162
Closes #163
🧪 Changes Made
✅ Checklist
None.
📸 Screenshots (if applicable)
N/A
🧩 Additional Notes
admin_verifyon a cancelled campaignverify_with_voteson a cancelled campaigncargo test test_voting_verify -- --nocapture).