ci: disable auto-review.yml workflow (closes #404)#405
Merged
Conversation
The auto-review workflow auto-merges PRs scored confidence>=0.7 by an LLM using `gh pr merge --admin`, bypassing branch protection. This is how PR #399 landed in a non-compiling state (#400, #401, #402). Beyond the --admin bypass, the file has multiple structural problems that cannot be patched without a full rewrite: - System prompt is configured to "APPROVE almost everything" with explicit instructions to ignore missing tests, no error handling, hardcoded values, etc. This framing is incompatible with a smart-contract project that custodies funds. - Runs on `pull_request_target` with `contents: write` permissions, a known supply-chain risk surface. - System prompt still references "Lernza, a hackathon project" (leftover from another repo) and merge commits inject `Co-authored-by: Dopey <hello@sshdopey.com>` on every auto-merge. - `actions/checkout@v6` is unpinned (tag, not SHA). This commit renames the file to `auto-review.yml.disabled` so GitHub Actions stops loading it. The file is preserved in the tree (not deleted) for reference if a future advisory bot is designed from scratch with safer foundations. CI (`ci.yml`) is unaffected. PR review is now fully human-driven. Closes #404
sshdopey
suggested changes
May 30, 2026
Contributor
sshdopey
left a comment
sshdopey
left a comment
There was a problem hiding this comment.
This PR has an empty or whitespace-only diff — no real code changes detected.
If you intended to push code, please commit it. Closing automatically; reopen once you have actual changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables
.github/workflows/auto-review.ymlby renaming it toauto-review.yml.disabledso GitHub Actions stops loading it. File is preserved in the tree (not deleted) for future reference.Opened as draft so the workflow being disabled does not attempt to auto-merge its own removal at confidence ≥0.7. Mark ready-for-review or merge directly from draft once you've confirmed.
Why disable rather than patch
Closes #404. The issue lists four concrete problems with the workflow. Three (admin bypass, branding leftovers, unpinned action) could be patched in place, but the fourth — the system prompt — cannot:
This is a hackathon-velocity prompt. It is structurally incompatible with a Soroban contract that custodies funds. A drop-in patch of the merge flags would leave an LLM in front of every PR instructed to wave through code with no error handling — exactly the opposite of what a smart-contract project needs.
If you want an advisory bot in the future, design it from scratch:
pull_request(notpull_request_target), so fork PRs run with no secrets and no write access.Effect on CI
.github/workflows/ci.ymlis unchanged. Tests + WASM build still run on every PR. Issue #403 (addfmt+clippyjobs) is the next CI hardening step.Test plan
.github/workflows/auto-review.ymlno longer exists in the workflows path after merge.ci.ymlstill runs on the test PR.