Skip to content

Landing Page Redesign + CI/CD Infrastructure #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Isaiahriveraa merged 8 commits into from
Dec 16, 2025
Merged

Landing Page Redesign + CI/CD Infrastructure #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a6416d
Summary:
Isaiahriveraa Dec 14, 2025
088f319
Summary:
Isaiahriveraa Dec 16, 2025
4f06178
Summary:
Isaiahriveraa Dec 16, 2025
0a5adfa
Summary:
Isaiahriveraa Dec 16, 2025
4bb497a
Summary:
Isaiahriveraa Dec 16, 2025
9566a54
Summary:
Isaiahriveraa Dec 16, 2025
c141bb2
Summary:
Isaiahriveraa Dec 16, 2025
513e50d
Summary:
Isaiahriveraa Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: CI

on:
push:
branches: [main, feature/*]
pull_request:
branches: [main]

jobs:
test:
name: Lint, Test & Build
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Run linter
run: npm run lint || true
# TODO: Remove "|| true" after cleanup branch fixes all lint errors
Comment on lines +28 to +29

Copilot AI Dec 16, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is configured to always pass (|| true) with a TODO comment indicating this is temporary. However, this silently allows lint errors to accumulate, which could make the eventual cleanup more difficult. Consider running the linter in a non-blocking informational mode that reports issues as warnings rather than silently suppressing them, or create a GitHub issue to track the cleanup work with a specific deadline.

Suggested change
run: npm run lint || true
# TODO: Remove "|| true" after cleanup branch fixes all lint errors
run: npm run lint
continue-on-error: true
# TODO: Track lint cleanup in a GitHub issue and set a deadline for enforcing lint errors

Copilot uses AI. Check for mistakes.

- name: Run tests
run: npm test

- name: Build application
run: npm run build
env:
# Skip env validation during CI build
SKIP_ENV_VALIDATION: true
# Provide dummy values for required env vars during build
MONGODB_URI: mongodb://localhost:27017/test
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: pk_test_dummy
CLERK_SECRET_KEY: sk_test_dummy
Comment on lines +36 to +42

Copilot AI Dec 16, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI workflow uses dummy environment variables (MONGODB_URI, CLERK keys) to allow the build to pass, but this approach could mask configuration issues that would only surface in production. Consider using a build-time check to validate that required environment variables are properly structured (even if dummy), or use Next.js environment variable validation to catch configuration problems earlier in the development cycle.

Copilot uses AI. Check for mistakes.
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,6 @@ next-env.d.ts
.next/

//CLAUDE
claude.md
claude.md
# Local Netlify folder
.netlify
11 changes: 11 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
echo "Running pre-commit checks..."

Copilot AI Dec 16, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit hook lacks a shebang line (#!/bin/sh or #!/usr/bin/env sh), which is required for proper execution. While Husky may work around this, it's a best practice to include a shebang to ensure the script runs in the correct shell environment across different systems.

Copilot uses AI. Check for mistakes.

# Skip lint for now - cleanup needed
# TODO: Re-enable after cleanup branch fixes all lint errors
# npm run lint || exit 1

# Run tests - these must pass
echo "Running tests..."
npm test || exit 1

echo "All checks passed!"
Loading
Loading