🔀 Feature/format figure#2
Merged
Merged
Conversation
Member
Author
Checklist for Pull Request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the population trend rendering pipeline, adds a new CLI command
render-population-trend, and introduces legend visibility control. 🚧Changes
Added
render-population-trend(replaces the now-deprecatedplot-population-trend)--show-legend/--no-show-legendoption torender-population-trendto control legend visibilityshow_legendparameter andhide_legend()method toPlotter_Population_Trend_ModelTests_Plotter_Population_Trend_Model_without_legendfor legend hiding behaviortests_no_hide_legendconfirming legend persists whenshow_legend=TrueChanged
_render_population_trendrefactored: acceptspd.DataFrameanddictinstead of file path strings; returns theGraficadorobject instead of saving the figure internally. File I/O responsibility moved to the CLI command functions.plot_population_trend(deprecated): now emits a deprecation warning via bothtyper.sechoandwarnings.warn, then delegates to the same internal logic.self.ax.legend()call inPlotter_Population_Trend_Model.__init__to ensure the legend artist exists beforehide_legend()can manipulate it.${m}variable to thegreenTDD commit message in the Makefile for commit message customization.test_render_population_trend_new_command_worksto pass--no-show-legend.Deprecated
plot-population-trendCLI command is deprecated in favor ofrender-population-trend. Will be removed in v6.0.0.Notes
plot_population_trend_from_cpuecommand is not affected by these changes.plot-population-trendcommand still works (with deprecation warnings).