🔀 Feature/renaming cli command#3
Merged
Merged
Conversation
MemoOlv
reviewed
May 11, 2026
Member
MemoOlv
left a comment
There was a problem hiding this comment.
Checklist for Pull Request
- Small: The pull request has fewer than 100 lines. Not fewer than 100 lines but OK. 109-12=97
- Passing: The CI pipeline is passing.
- Technical debt reduction: Did we reduce any form of technical debt? Are we confident that this change did not introduce or increase technical debt?
- Complexity: Could the code be made simpler? Would another developer be able to easily understand and use this code when they come across it in the future? Is this code adding functionality that isn't presently needed?
- Design: Is the code well-designed and appropriate for your system?
- Tests: Does the code have correct and well-designed automated tests? Does the code behave as the author likely intended?
- Interface: Any interface changes are sensible and look good. Is the way the code behaves good for its users?
We need to add the v5.11.0 version.
- CHANGELOG.md: Are the changes recorded in this file following this standard?
- Versioning: Are version numbers updated according to semantic versioning guidelines (e.g., MAJOR.MINOR.PATCH)?
-
Documentation: Did the developer also update relevant documentation? Does the exposed functions have docstrigns?No tenemos pero nos vamos a pasar de líneas. - ~~ CITATION.cff: Is the citation files included and updated following the this standard? Aquí y aquí hay ejemplos.~~No tenemos pero nos vamos a pasar de líneas.
- Naming: Did the developer choose clear names for variables, classes, methods, etc.? Did we replace unnecessary comments with clear variable names, well-named functions, and small cohesive blocks?
-
Style: Does the code follow our style guides?Function_render_population_trend()is going to change in next PR.
- YAGNI: The developer is not implementing things they might need in the future but don’t know they need now.
- Good Things: If you see something nice in the pull request, tell the developer, especially when they addressed one of your comments in a great way.
MemoOlv
requested changes
May 11, 2026
Member
MemoOlv
left a comment
There was a problem hiding this comment.
Please, update version in CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plot-population-trendtorender-population-trend, marking the old name as deprecated.developbranch, preventing accidental releases fromfeature/*branches.
_render_population_trend()helper to eliminate duplication between old and new commands.Changes
CLI (
population_trend/cli.py)render-population-trendcommand (same interface, same behavior).plot-population-trendwith:deprecated=Trueflag;typer.secho()yellow warning to stderr at invocation;warnings.warn(DeprecationWarning)for programmatic consumers._render_population_trend()private function (DRY).CI/CD (
.github/workflows/actions.yml)feature/*to push triggers.if: github.ref_name == 'develop'so feature branches run tests/lint only.Changelog (
CHANGELOG.md)Refactoring (
population_trend/population_growth_model.py)set_labels()to use a dictionary structure, laying groundwork for future localization (extensibility without behavioral change).Tests (
tests/test_cli.py,tests/test_Population_trend.py)Plottermoved afterSparse_Plotter).output_figurewithdata_path_for_trend).test_app_plot_population_trendto verify deprecation notice and new command name appear in help output.test_render_population_trend_new_command_worksto validate the new command produces output correctly.Migration path
Users can safely replace
plot-population-trendwithrender-population-trendin scripts. The old name continues to work but emits deprecation warnings. Removal is planned for v6.0.0.