Skip to content

🔀 Feature/set axis language from class#4

Merged
MemoOlv merged 10 commits into
developfrom
feature/set_axis_language_from_class
May 12, 2026
Merged

🔀 Feature/set axis language from class#4
MemoOlv merged 10 commits into
developfrom
feature/set_axis_language_from_class

Conversation

@mvillasante
Copy link
Copy Markdown
Member

@mvillasante mvillasante commented May 11, 2026

Description

Add language argument to class Plotter_Population_trend_model in order to select axis labels laguange

Checklist for Pull Request

  • Small: The pull request has fewer than 100 lines.
  • Passing: The CI pipeline is passing.
  • Technical debt reduction: Did we reduce any form of technical debt? Are we confident that this change did not introduce or increase technical debt?

  • Complexity: Could the code be made simpler? Would another developer be able to easily understand and use this code when they come across it in the future? Is this code adding functionality that isn't presently needed?
  • Design: Is the code well-designed and appropriate for your system?
  • Tests: Does the code have correct and well-designed automated tests? Does the code behave as the author likely intended?
  • Interface: Any interface changes are sensible and look good. Is the way the code behaves good for its users?

  • CHANGELOG.md: Are the changes recorded in this file following this standard?
  • Versioning: Are version numbers updated according to semantic versioning guidelines (e.g., MAJOR.MINOR.PATCH)?
  • Documentation: Did the developer also update relevant documentation? Does the exposed functions have docstrigns?
  • ~~CITATION.cff: Is the citation files included and updated following the this standard? Aquí y aquí hay ejemplos. ~~

  • Naming: Did the developer choose clear names for variables, classes, methods, etc.? Did we replace unnecessary comments with clear variable names, well-named functions, and small cohesive blocks?
  • Style: Does the code follow our style guides?

  • YAGNI: The developer is not implementing things they might need in the future but don’t know they need now.
  • Good Things: If you see something nice in the pull request, tell the developer, especially when they addressed one of your comments in a great way.

@mvillasante mvillasante requested a review from MemoOlv May 12, 2026 17:43
Copy link
Copy Markdown
Member

@MemoOlv MemoOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 LGMT

@MemoOlv MemoOlv merged commit 47e424f into develop May 12, 2026
2 checks passed
@MemoOlv MemoOlv deleted the feature/set_axis_language_from_class branch May 12, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants