Fix pkg resources#17
Open
EJ-PJ wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I recently came across whit this great tool for visualize xinput devices and edit their parameters.
While testing the project on recent Python versions (specifically Python 3.12+), I noticed some import errors.
The tool currently triggers a
ModuleNotFoundError: No module named 'pkg_resources'.This is because "pkg_resources (part of setuptools) has been deprecated and was removed from the standard library starting with Python 3.12."(A more in-depth look at the issue can be found here: mu-editor/mu#2485 (comment))
This PR addresses the issue by replacing the deprecated
pkg_resourcesimports withimportlib.resources.I hope this can be merged into the master branch or, at the very least, help others get this tool working on modern Python versions.