Skip to content

[01166] Change token.json popover colors in dark theme to card-dark#13

Merged
dcrjodle merged 1 commit into
mainfrom
plan-01166-Ivy-Design-System
Apr 8, 2026
Merged

[01166] Change token.json popover colors in dark theme to card-dark#13
dcrjodle merged 1 commit into
mainfrom
plan-01166-Ivy-Design-System

Conversation

@dcrjodle

@dcrjodle dcrjodle commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Changes

Changed the dark theme color.popover token from {ivy-framework.source.color.black} (#000000) to {ivy-framework.source.color.card-dark} (#171717). This aligns popover backgrounds with card backgrounds in dark mode, providing a consistent elevated surface color instead of pure black.

API Changes

  • --color-popover CSS variable in dark theme: #000000 -> #171717
  • IvyFrameworkDarkThemeTokens.Popover C# property: "#000000" -> "#171717"

Files Modified

  • figma-tokens/$tokens.json — Updated dark theme popover color reference

Commits

  • 8bb3550 [01166] Change dark theme popover color from black to card-dark

Update dark theme color.popover token to reference card-dark (#171717)
instead of black (#000000), matching the card surface color for
consistent elevated surface styling in dark mode.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dcrjodle
dcrjodle merged commit 981584a into main Apr 8, 2026
2 checks passed
@rorychatt
rorychatt deleted the plan-01166-Ivy-Design-System branch June 25, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant