Skip to content

fix workflow#202

Merged
rorychatt merged 16 commits into
Ivy-Interactive:mainfrom
MedhatZ:feat/zstring-example
Oct 1, 2025
Merged

fix workflow#202
rorychatt merged 16 commits into
Ivy-Interactive:mainfrom
MedhatZ:feat/zstring-example

Conversation

@MedhatZ

@MedhatZ MedhatZ commented Sep 29, 2025

Copy link
Copy Markdown

This PR adds a new Ivy demo application showcasing the usage of Cysharp.ZString for high-performance string operations in .NET.

  • Demonstrates string concatenation, formatting, joining, and prepared templates.
  • Provides simple interactive console/UI examples.
  • Includes Docker config and project setup for easy development and testing.

@MedhatZ

MedhatZ commented Sep 29, 2025

Copy link
Copy Markdown
Author

Hi ,
The CI pipeline is now passing successfully ✅.
Here’s the latest run for the feat/zstring-example branch:

All checks are green and the build summary is generated correctly.

Best,

rrrr

@nielsbosma
nielsbosma requested a review from Copilot September 30, 2025 04:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Ivy demo application showcasing ZString usage for high-performance string operations and includes workflow optimizations for better CI/CD handling of pull requests.

  • Added ZString demo application with interactive console examples
  • Simplified GitHub Actions workflow by removing comment noise and improving PR handling
  • Enhanced workflow to properly checkout PR branches for accurate builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/build-all-projects.yml Outdated
Comment thread .github/workflows/build-all-projects.yml
Comment thread .github/workflows/build-all-projects.yml Outdated
Comment thread .github/workflows/build-all-projects.yml Outdated
@MedhatZ

MedhatZ commented Sep 30, 2025

Copy link
Copy Markdown
Author

✅ Fixed the issues raised in the earlier review:

Removed checkout duplication → unified checkout configuration across jobs.

Improved readability of the jq command with simplified logic and inline comments.

Corrected success message wording (removed the misleading "or skipped").

All workflows are now green and running cleanly. 🚀

@rorychatt
rorychatt requested a review from Copilot October 1, 2025 07:38
@rorychatt

Copy link
Copy Markdown
Collaborator

Hey. Wow.

image

I guess PR was originally for something else. I will rename it and merge it!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/build-all-projects.yml Outdated
Comment thread .github/workflows/build-all-projects.yml
@rorychatt rorychatt changed the title Feat/zstring example fix workflow Oct 1, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rorychatt
rorychatt merged commit 77f3eef into Ivy-Interactive:main Oct 1, 2025
31 checks passed
@MedhatZ

MedhatZ commented Oct 1, 2025

Copy link
Copy Markdown
Author

Thanks for the review and merge! Appreciate the fixes and guidance on workflow security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants