More plugin fixes#4725
Draft
zachwolfe wants to merge 6 commits into
Draft
Conversation
…figured Both LoadPlugin and ReloadPlugin had early returns for the 'loaded but unconfigured' path that skipped firing PluginLoaded/PluginReloaded events. This caused the UI to stay stuck showing the initial failure message (e.g. 'No DLL files found') even after the plugin successfully loaded.
Allows callers to render additional buttons (e.g. Uninstall) inline with the Save button row rather than in a separate section below.
Previously, the external widget registry was only sent during the initial root SignalR connection. Plugins installed at runtime registered their widgets on the backend but never notified connected clients, causing 'Unknown component type' errors until a browser refresh.
…ions on failure Plugins loaded before the app is built (via deferred loading) would crash with "UseEndpoints cannot be called before the application is built" because the background task could reach Configure before Apply(app) set up the endpoint data source. Now UseEndpoints queues registrations when the app isn't ready and replays them in Apply(), making plugins lifecycle-agnostic. Additionally, when a plugin's Configure throws partway through (leaving partial apps/endpoints/hooks registered), the contributions are now rolled back via RemovePluginContributions so the UI doesn't show ghost entries from failed plugins. This applies to both initial load and reload paths.
PluginCandidate now carries the plugin's Title and Icon so the UI can show human-readable names and icons for unloaded/failed plugins instead of raw IDs.
Collaborator
Staging preview📄 Docs: https://ivy-framework-staging-docs-4725.sliplane.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.