Flag test-fixture components as auxiliary#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the auxiliary-component path matcher in
ComponentDetectorto also flag hyphenated test-fixture / test-suite path segments (test-site,test-suite,testdata) as auxiliary, alongside the existingexample/tests/e2e/fixturessegments.Motivation (from the firecrawl review):
apps/test-site(an Astro scraping fixture) andapps/test-suite(a Jest e2e harness) were reported withisAuxiliary=false, leaking high-confidenceAstro [framework]andJest [testing]tokens into the significant-stack hash. The existing matcher used exact segment equality, so hyphenated names did not match. They are now flagged auxiliary, consistent withexamples/**.Note:
testdata/is added to the segment list for completeness, but in practice such dirs are already excluded as vendored (vendor.yml), so the focused test covers the two hyphenated cases that actually surface as components.Test result
96/96 passing (baseline 95 + 1 new focused test
Test_fixture_and_suite_components_are_auxiliary).Snapshots
No snapshot changes required; all
*.verified.yamlsnapshots remained green.