Detect SQLite/BigQuery/Postgres/SQL Server; move secret-manager to saas#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements five database-detector suggestions from
src/.review/. All changes are indata/detectors/database.yml(embedded, auto-loaded).Changes
sqlite-database-missed.md): extendedsqlitedeps with NuGet (Microsoft.EntityFrameworkCore.Sqlite,Microsoft.Data.Sqlite[.Core],System.Data.SQLite,sqlite-net-pcl),depPrefixforSQLitePCLRaw., pypiaiosqlite, and an EF Core nuget regex.bigquery-database-not-detected.md): addeddepPrefixGoogle.Cloud.BigQuery(nuget) to the existinggcp.bigqueryentry, surfacing the .NET provider.postgres-database-missed.md): extendedpostgresqldeps with Go drivers (jackc/pgx/v5,pgx/v4,pgconn,lib/pq) and async-Rust drivers (tokio-postgres,bb8-postgres,deadpool-postgres,postgres-protocol,sqlx-postgres).sqlserver-database-not-detected.md): extended the existingmssqlentry with NuGet (Microsoft.EntityFrameworkCore.SqlServer,Microsoft.Data.SqlClient,System.Data.SqlClient,Dapper.SqlBuilder), Go/Rust/pypi drivers (go-mssqldb,microsoft/go-mssqldb,tiberius,pyodbc,pymssql), and an EF Core SqlServer nuget regex..sqlfiles) is a T-SQL content-sniff. That requires addingRequiresContent/content-sniff support to the techRuleEngine(onlyInfraScannerhas it today); deferred to avoid a half-working engine change. The dep/files-based detection above is implemented and lands SQL Server for any repo with a real .NET/Go/Rust/pypi SQL Server dependency.secret-manager-miscategorized-as-database.md): movedgcp.secretmanager,scaleway.secretmanager,aws.secretsmanager, andhashicorp_vaultfromcategory: databasetocategory: saas(existing category) so secrets/config stores stop polluting thedb:hash slot.Testing
dotnet buildclean;dotnet test95/95 passed (baseline 95).rulesLoadedunchanged at 740 (existing entries extended, no rules added/removed).Snapshots
Updated
next-dotnet-monorepo.verified.yaml: SQL Server now correctly surfaces fromMicrosoft.EntityFrameworkCore.SqlServer(newMS SQLdatabase technology row) — expected diff, accepted.