[00037] Fix clippy unnecessary casts in lib.rs and unsafe extern in bench file#16
Merged
Merged
Conversation
Remove 6 redundant `as *const u8` casts from `&str::as_ptr()` calls in test module of lib.rs, and add `unsafe` keyword to `extern "C"` block in diff_bench.rs for Rust 2024 edition compliance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed 6 redundant
as *const u8casts from&str::as_ptr()calls in the test module ofsrc/RustServer/src/lib.rs, and addedunsafekeyword to theextern "C"block insrc/RustServer/benches/diff_bench.rsfor Rust 2024 edition compliance. These changes fix 7 clippy errors that appear when runningcargo clippy --benches -- -D warnings.API Changes
None.
Files Modified
src/RustServer/src/lib.rs- Removed unnecessaryas *const u8casts in test helper functions (diff(),apply()) and test cases (test_apply_patch_null_json,test_apply_patch_null_patch)src/RustServer/benches/diff_bench.rs- Changedextern "C"tounsafe extern "C"for the FFI function declarations blockCommits