[00056] Align cross-language benchmark data generation#19
Merged
Conversation
…VeryLargeStateTree Align C# GenerateVeryLargeStateTree() numeric values with Rust diff_bench.rs by replacing System.Random calls with identical arithmetic expressions (e.g. salary, skill level, yearsExperience, performanceScore). Add test validating formula outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced
System.Random-based numeric generation inGenerateVeryLargeStateTree()with deterministic arithmetic expressions that match the Rustgenerate_very_large_state_tree()indiff_bench.rs. This ensures cross-language benchmark comparisons use identical numeric values for salary, skill level, years of experience, and performance score. Added a test validating representative values match the expected formulas.Files Modified
src/Ivy.NativeJsonDiff.Benchmarks/TestData/JsonPayloadGenerator.cs— ReplacedRandomcalls with arithmetic expressions inGenerateVeryLargeStateTree(), removedRandom rngparameter fromBuildEmployeesrc/Ivy.NativeJsonDiff.Tests/JsonPayloadGeneratorTests.cs— AddedVeryLargeStateTree_UsesArithmeticFormulasMatchingRusttestCommits