[00062] Rename NativeJsonDiff class to JsonDiffer to resolve namespace ambiguity#22
Merged
Merged
Conversation
Resolves namespace-type ambiguity where C# couldn't distinguish Ivy.NativeJsonDiff (namespace) from NativeJsonDiff (class) in consumers within the Ivy.* namespace. - Rename class NativeJsonDiff → JsonDiffer in all source files - Rename NativeJsonDiff.cs → JsonDiffer.cs - Update all test and benchmark references - Update benchmark method names and report generator filters - Update README code examples and API reference - Bump version 1.0.0 → 2.0.0 (breaking change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renamed the public static class
NativeJsonDifftoJsonDifferin theIvy.NativeJsonDiffpackage to resolve namespace-type ambiguity. Bumped the package version from 1.0.0 to 2.0.0 since this is a breaking change for all consumers.API Changes
Ivy.NativeJsonDiff.NativeJsonDiff->Ivy.NativeJsonDiff.JsonDifferJsonDiffer.ComputePatch(byte[] oldTreeBytes, byte[] newTreeBytes)(unchanged signature)JsonDiffer.ApplyPatch(byte[] jsonBytes, byte[] patchBytes)(unchanged signature)Files Modified
src/Ivy.NativeJsonDiff/NativeJsonDiff.cs->src/Ivy.NativeJsonDiff/JsonDiffer.cs(renamed file, renamed class)src/Ivy.NativeJsonDiff.Tests/NativeJsonDiffTests.cs(updated 20 class references)src/Ivy.NativeJsonDiff.Tests/ReportGeneratorTests.cs(updated test data and assertions)src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/EndToEndDiffBenchmarks.cs(updated method name and class ref)src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/PreParsedDiffBenchmarks.cs(updated method name and class ref)src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/JsonApplyBenchmarks.cs(updated method names and class refs)src/Ivy.NativeJsonDiff.Benchmarks/ReportGenerator.cs(updated string filters and display text)Directory.Build.props(version 1.0.0 -> 2.0.0)README.md(updated code examples and API reference)Commits
42d9887