[00108] Restore ThreadingDiagnoser and upgrade BenchmarkDotNet to 0.15.x#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgraded BenchmarkDotNet from 0.14.x to 0.15.x in the benchmarks project and restored the
[ThreadingDiagnoser]attribute to all three benchmark classes (EndToEndDiffBenchmarks,JsonApplyBenchmarks,PreParsedDiffBenchmarks). This re-enables thread contention metrics that were removed in plan 00092 due to .NET 10 TFM incompatibility in BenchmarkDotNet 0.14.x.Files Modified
src/Ivy.NativeJsonDiff.Benchmarks/Ivy.NativeJsonDiff.Benchmarks.csproj— BenchmarkDotNet version 0.14.* -> 0.15.*src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/EndToEndDiffBenchmarks.cs— added[ThreadingDiagnoser]src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/JsonApplyBenchmarks.cs— added[ThreadingDiagnoser]src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/PreParsedDiffBenchmarks.cs— added[ThreadingDiagnoser]Commits
1b61df1[00108] Upgrade BenchmarkDotNet to 0.15.x and restore ThreadingDiagnoser