[00115] Remove Small and Medium benchmark categories#29
Merged
Conversation
Small (~200B) and Medium (~2KB) payloads produce misleading results where FFI marshalling overhead dominates over actual diff computation, making NativeJsonDiff appear slower than managed alternatives. - Remove Small/Medium from AllCategories, Generate() switch, and delete GenerateSmall()/GenerateMedium() methods - Remove Small/Medium from [Params] in all three benchmark classes - Remove Small/Medium rows from README.md and BENCHMARKS.md tables - Update tests: remove InlineData, Assert.Contains, fix category count Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed Small (~200B) and Medium (~2KB) benchmark categories from all benchmark classes, the payload generator, README tables, BENCHMARKS.md tables, and tests. These categories produced misleading results where FFI marshalling overhead dominated over actual diff computation time.
API Changes
JsonPayloadGenerator.AllCategoriesreduced from 10 to 8 entries (removed "Small" and "Medium")JsonPayloadGenerator.Generate()no longer accepts "Small" or "Medium" as argumentsGenerateSmall()andGenerateMedium()private methods deletedFiles Modified
src/Ivy.NativeJsonDiff.Benchmarks/TestData/JsonPayloadGenerator.cs— removed Small/Medium from AllCategories, switch, and deleted generator methodssrc/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/EndToEndDiffBenchmarks.cs— removed from [Params]src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/PreParsedDiffBenchmarks.cs— removed from [Params]src/Ivy.NativeJsonDiff.Benchmarks/Benchmarks/JsonApplyBenchmarks.cs— removed from [Params]README.md— removed Small/Medium rows from tables, updated category countBENCHMARKS.md— removed Small/Medium rows from all three tablessrc/Ivy.NativeJsonDiff.Tests/JsonPayloadGeneratorTests.cs— removed InlineData, Assert.Contains, updated count assertionCommits
215c095[00115] Remove Small and Medium benchmark categories