Release: Merge development into main (v0.3.9)#21
Merged
Merged
Conversation
Ivy-Tendril#1682: the first desktop notification on macOS popped an OS "Where is use_default?" app-picker dialog. rustino_show_notification ignored app_id on macOS and called notify_rust::Notification::show() without ever calling set_application. notify-rust's macOS backend then lazily resolved the bundle id for the literal string "use_default" via AppleScript, and macOS showed a picker dialog for the unrecognized app name. Fix: before the first notification, call notify_rust::set_application exactly once (guarded by a std::sync::Once, since mac-notification-sys latches its own Once even on failure). Try, in order: the app_id FFI param, the running app's own bundle id (NSBundle mainBundle), then "com.apple.Terminal", each pre-validated against LaunchServices via NSWorkspace::URLForApplicationWithBundleIdentifier so we never call set_application with an id it would reject; fall back to "com.apple.Finder" (always installed) if nothing validates. Windows/Linux notification behavior is unchanged.
…lt-dialog Fix macOS "Where is use_default?" dialog on first desktop notification
Collaborator
Author
|
@claude review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated release PR for version 0.3.9.