Conservemass #1
Open
Conservemass #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanged lower mass to minimum of isochrones
…oupa appears buggy
Owner
|
Sorry for the delay, I'm travelling at the moment I'll take a proper look into it when I'm back, but for now, I'm not surprised there's issues with very faint magnitude limits as it's only really been tested to 20th mag. A very faint magnitude limit may result in you generating hundreds of billions of stars, so you may run into memory issues if nothing else. The GRVS cut shouldn't be in the master version, so thanks for spotting that! I'm going to rework the interpolation routine shortly anyway when upgrading to a newer set of isochrones, but I'll also go through this when I'm back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played with Snapdragons a bit. Nice tool, but it appears to have some bugs. When I set the limiting magnitude to a very large value, like 1000, I got nonsensical behavior (hangs, or no selected stars, depending on the exact value). This pull request has some suggested changes. Certainly I don't understand the code that well, so consider it all carefully! Also ignore the configuration changes in the beginning.