Skip to content

Pass the release flag as part of one options array #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDS300 merged 1 commit into from
Aug 14, 2026
Merged

Pass the release flag as part of one options array #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/build-loremaster.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,11 +547,17 @@ jobs:
gh release edit $tag --repo $env:GITHUB_REPOSITORY --prerelease=false --latest
}
} else {
$flags = if ($prerelease) { @('--prerelease') } else { @('--latest') }
gh release create $tag @assets --repo $env:GITHUB_REPOSITORY @flags `
--target $env:GITHUB_SHA `
--title "SpinUI $tag — Vellum & Ember + Glass" `
--notes "Complete SpinUI Windows release. Extract SpinUI-Manual.zip for both the classic spinui_reloaded skin and optional spinui_glass skin, layout profiles, manual guide, and the portable TypeScript/Electron Loremaster. Verify downloads against SHA256SUMS.txt; the unsigned Loremaster executable can trip antivirus machine-learning heuristics (see the README's Troubleshooting section).$candidateNote"
# Built as one array rather than splatting a conditional: an if
# expression returning a single-element array unrolls to a bare
# string, and splatting that string fed gh a lone "-" which it
# tried to read as an asset filename.
$options = @(
'--target', $env:GITHUB_SHA,
'--title', "SpinUI $tag — Vellum & Ember + Glass",
'--notes', "Complete SpinUI Windows release. Extract SpinUI-Manual.zip for both the classic spinui_reloaded skin and optional spinui_glass skin, layout profiles, manual guide, and the portable TypeScript/Electron Loremaster. Verify downloads against SHA256SUMS.txt; the unsigned Loremaster executable can trip antivirus machine-learning heuristics (see the README's Troubleshooting section).$candidateNote"
)
if ($prerelease) { $options += '--prerelease' } else { $options += '--latest' }
gh release create $tag @assets --repo $env:GITHUB_REPOSITORY @options
}

- name: Attach package to release
Expand Down