Repository navigation
fixed the bug based on Claude's suggestion - #137
Merged
Merged
Conversation
chunshen1987
requested review from
jhputschke and
latessa
and
a lite review from Copilot
September 23, 2026 11:53
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain.
Review effort: Lite
Findings: None
What changed in this PR
Fixes the calculation of (u^0) from three-velocity components when preparing surface cells.
Changes:
- Computes the Lorentz factor using (1/\sqrt{1-v^2}).
| File | Description |
|---|---|
src/framework/SurfaceFinder.cc |
Corrects four-velocity initialization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
latessa
approved these changes
Sep 24, 2026
latessa
left a comment
latessa
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the update. I've redirected the pull request to the release candidate branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the calculation for u^0 from three velocities v when preparing surface cells.