Repository navigation
update MUSIC - #138
update MUSIC#138
Conversation
Allow adding source terms to hydro from 3D-Glauber and jet energy deposition
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Configure the from-jet path only when a source provider is present to avoid unnecessary full-grid processing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates MUSIC integration to support both 3D-Glauber and jet energy-deposition source terms.
Changes:
- Registers JETSCAPE sources through MUSIC’s dedicated jet-source API.
- Pins a compatible MUSIC revision.
| File | Summary |
|---|---|
src/hydro/MusicWrapper.cc |
Registers JETSCAPE source terms with MUSIC; the from-jet path is enabled unconditionally. |
external_packages/get_music.sh |
Updates the pinned MUSIC dependency revision. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // need further improvement to accept multiple source term objects | ||
| // this is a temporary solution | ||
| music_hydro_ptr->add_hydro_source_terms(hydro_source_terms_ptr); | ||
| music_hydro_ptr->add_hydro_source_terms_from_jet(hydro_source_terms_ptr); |
There was a problem hiding this comment.
Doing some investigating on this, will report back when I have something
latessa
left a comment
latessa
left a comment
There was a problem hiding this comment.
I've redirected the PR to the XSCAPE-2.1.1 release candidate branch.
Looks good. I'll hold off on merging in case you're waiting for comments from other reviewers.
#138, commit 668893e (Chun Shen): pin MUSIC to cee9460 and route the X-SCAPE liquefier source into MUSIC's new jet source slot (add_hydro_source_terms_from_jet), so 3D-Glauber strings (InitialProfile 131) and jet energy deposition can both drive the hydro. The music4gpu side of the same change is not in yet; build_gpu needs the matching MUSIC4GPU port (jet source slot) before it compiles again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019CrjXPHRbBKFbRYS7cdbKC
|
@chunshen1987, are you waiting for any additional reviewer comments, or is this ready to merge into the release candidate? |
Allow adding source terms to hydro from 3D-Glauber and jet energy deposition