Decouple post-PR review from /ship, make it opt-in, compress ship.md (#83)#84
Merged
Conversation
…ess ship.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…contained Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ationale) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion Introduces `review.model` config (default `auto`) and a right-sizing heuristic that selects haiku/sonnet/opus based on diff scope and risk, dispatching fix-application edits via a model-tiered subagent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add --autonomous[=<level>] flag parsing to step 2 of review.md, defining AUTONOMOUS_LEVEL and AUTONOMOUS with the same semantics as ship.md/start.md. Also documents that a PR number may be passed explicitly (forwarded by /ship). The existing Autonomous bypass paragraph in step 5a already references AUTONOMOUS correctly; this change makes it well-defined rather than relying on an undefined var. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…% smaller Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eview.model auto, deprecate copilot.enabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…op to /review Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….md step refs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83.
Summary
review.providerdefaults tonone;/shipcreates the PR and stops unless review is explicitly configured or/goalruns it. Legacycopilot.enabledis deprecated (no longer consulted).review.mdis the canonical home of the review loop. The Copilot polling loop, GraphQL thread reply/resolve, HITL invocation gate,--autonomousbypass, and draft promotion moved out ofship.mdintoreview.md.ship.mdis now a thin delegator that invokes/gh-issue-driven:reviewonly when review is requested.ship.mdshrank ~40% (1102 → 663 lines); ship/review duplication removed.review.model(auto|haiku|sonnet|opus, defaultauto) right-sizes the fix-application model by diff scope/risk.goal.inner_review.modeldefault is nowauto./goalconsumes the unchangedreview.*state contract (prose-only update).Design
docs/superpowers/specs/2026-06-05-ship-review-decouple-design.mddocs/superpowers/plans/2026-06-05-ship-review-decouple.mdTest Plan
tests/jq-sync-check.sh(detect-filter anchor repointed to review.md)tests/enum-sync-check.sh(schema/exit_reason → review.md; autonomy enum incl. review.md)tests/copilot-detection.shtests/review-threads.shtests/test_state_schema.shtests/test_verdict_parser.pyship.mdreduced to 663 lines; no residual JQ_DETECT_FILTER / step-14.x refs; gate2 + PR +--review=code-reviewerpaths intact🤖 Generated with Claude Code