Skip to content

Decouple post-PR review from /ship, make it opt-in, compress ship.md (#83)#84

Merged
JFK merged 19 commits into
mainfrom
feat/83-decouple-ship-review
Jun 5, 2026
Merged

Decouple post-PR review from /ship, make it opt-in, compress ship.md (#83)#84
JFK merged 19 commits into
mainfrom
feat/83-decouple-ship-review

Conversation

@JFK

@JFK JFK commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Closes #83.

Summary

  • Post-PR review is now opt-in. review.provider defaults to none; /ship creates the PR and stops unless review is explicitly configured or /goal runs it. Legacy copilot.enabled is deprecated (no longer consulted).
  • review.md is the canonical home of the review loop. The Copilot polling loop, GraphQL thread reply/resolve, HITL invocation gate, --autonomous bypass, and draft promotion moved out of ship.md into review.md. ship.md is now a thin delegator that invokes /gh-issue-driven:review only when review is requested.
  • ship.md shrank ~40% (1102 → 663 lines); ship/review duplication removed.
  • New review.model (auto|haiku|sonnet|opus, default auto) right-sizes the fix-application model by diff scope/risk. goal.inner_review.model default is now auto.
  • /goal consumes the unchanged review.* state contract (prose-only update).

Design

  • Spec: docs/superpowers/specs/2026-06-05-ship-review-decouple-design.md
  • Plan: docs/superpowers/plans/2026-06-05-ship-review-decouple.md

Test Plan

  • tests/jq-sync-check.sh (detect-filter anchor repointed to review.md)
  • tests/enum-sync-check.sh (schema/exit_reason → review.md; autonomy enum incl. review.md)
  • tests/copilot-detection.sh
  • tests/review-threads.sh
  • tests/test_state_schema.sh
  • tests/test_verdict_parser.py
  • ship.md reduced to 663 lines; no residual JQ_DETECT_FILTER / step-14.x refs; gate2 + PR + --review=code-reviewer paths intact

🤖 Generated with Claude Code

JFK and others added 19 commits June 5, 2026 10:20
…ess ship.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…contained

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… loop

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ationale)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion

Introduces `review.model` config (default `auto`) and a right-sizing
heuristic that selects haiku/sonnet/opus based on diff scope and risk,
dispatching fix-application edits via a model-tiered subagent.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add --autonomous[=<level>] flag parsing to step 2 of review.md, defining
AUTONOMOUS_LEVEL and AUTONOMOUS with the same semantics as ship.md/start.md.
Also documents that a PR number may be passed explicitly (forwarded by /ship).
The existing Autonomous bypass paragraph in step 5a already references AUTONOMOUS
correctly; this change makes it well-defined rather than relying on an undefined var.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…% smaller

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eview.model auto, deprecate copilot.enabled

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…op to /review

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….md step refs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@JFK JFK merged commit bb56458 into main Jun 5, 2026
1 check passed
@JFK JFK deleted the feat/83-decouple-ship-review branch June 5, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple post-PR review from /ship, make it opt-in, compress ship.md

1 participant