refactor: v0.14.0 verified-safe cleanups (close the inflated compression milestone)#96
Merged
Merged
Conversation
The v0.14.0 "token + precision optimization" milestone was re-audited against the actual files (using the token-baseline tool from #94). The premise turned out to be largely invalid: - The "~28% / ~6,400 token" compression is not achievable: slash commands load whole (no runtime include / conditional load), so relocating sections to an appendix saves nothing, and the bulk of start.md/ship.md is load-bearing executable spec that must not be compressed. - The claimed precision bugs were phantom: step-18b precedence is already an If/Else-if chain; verdict last-wins is already explicit (and now test-guarded by #95); the propose.md "parallel Skill" instruction is correct (batched Skill calls are supported); the propose.md "regex mismatch" is a harmless subset, not a contradiction. This commit ships the ONLY verified-safe, genuinely-beneficial residue: - start.md: delete a verbatim-redundant `lang != "en"` localization line (649) that duplicated line 647. - goal.md: convert the red-verdict force-continue prose (phase-aware bullets) into a compact decision table, preserving every load-bearing detail (the gate2.binary_gate `fail` exception, phase routing, continue-to steps). Net effect (per tests/token-baseline.sh): TOTAL ~78,424 -> ~78,355 tokens (-69 tokens, -0.09%). The negligible number is itself the finding — it demonstrates the milestone's compression premise was unfounded, and the token-baseline tool (#87/#94) measuring it is working as intended. Closes #89 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
TL;DR
The v0.14.0 "token + precision optimization" milestone was re-audited against the actual files (using the token-baseline tool shipped in #94). Its premise turned out to be largely invalid. This PR ships the only verified-safe, genuinely-beneficial residue — two small cleanups netting −69 tokens (−0.09%). That negligible number is the finding.
What the re-audit found
Compression is mostly infeasible, not "~28% / ~6,400 tokens":
start.md/ship.mdis load-bearing executable spec (gate contracts, state schema, the## Verdict:parser regex, the "Invoke /plugin:command via the Skill tool" phrasing). Compressing it is not a safe token play.The precision "bugs" were phantom:
If / Else if / Elsechain (start.md:1034-1037).start.md:556,575,611) — and now test-guarded by test: add decline-token coverage to the verdict-parser contract (#88) #95.[a-z0-9 ]⊆ validation[a-zA-Z0-9 _.:-]), not a contradiction.What this PR actually does (the safe residue)
lang != "en"localization line (was line 649) that duplicated line 647.gate2.binary_gatefailexception, phase routing, continue-to steps).tests/fixtures/token-baseline.txt(per the test: deterministic token-count baseline for command files #87 workflow): TOTAL ~78,424 → ~78,355 tokens.Milestone disposition
scripts/directory" principle (CONTRIBUTING.md:24), doesn't reduce runtime tokens, and its "retire jq-sync-check" claim is incorrect.The real value of this whole effort already shipped: #94 (the token-baseline measurement tool) and #95 (decline-token parser contract coverage). Those are worth keeping; the compression headline was not real.
Verification
tests/token-baseline.sh --check→ reductions shown; snapshot refreshed.🤖 Generated via /gh-issue-driven (milestone v0.14.0 wind-down)