Repository navigation
Generate generic label bands from explicit input scales - #38
Merged
Merged
Conversation
JGAguado
approved these changes
Oct 21, 2026
JGAguado
left a comment
Owner
There was a problem hiding this comment.
Nice to have the label bands and firmware scales come from one contract. The pinned dependencies and the MIT notice for Label-maker are fine. Approving.
flowcool
force-pushed
the
publish/73-label-generator
branch
from
October 21, 2026 15:43
91403cc to
998270c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate a generic e-paper label from explicit YAML without device inventory or Home Assistant data. Recommendation bands and firmware scales share one geometry contract.
This optional adaptation credits Label-maker and preserves its MIT notice. Include the generated scale package after the core; device substitutions still take precedence. Firmware source is unchanged. CI installs the pinned renderer dependencies and Cairo build tools.
Evidence
After: 26 tests pass on this refreshed upstream base, with no skips. Tests execute the real firmware gauge, compare rendered endpoints, reject invalid input, check deterministic output, and exercise the ESPHome 2026.9.0 package loader.
Merge Danger
Door: two-way. Revert this optional tool and its CI dependencies; generated local files remain user-owned.
Blast Radius: tooling. No firmware deployment. Custom scales can change needle interpretation when a user later adopts the generated package.
AI assistance: Codex prepared and validated this isolated contribution. Upstream review is requested; local tests do not constitute maintainer approval.