Skip to content

Require explicit credentials in generic examples - #45

Open
flowcool wants to merge 1 commit into
JGAguado:V2R1from
flowcool:upstream/42-access
Open

flowcool wants to merge 1 commit into
JGAguado:V2R1from
flowcool:upstream/42-access

Conversation

@flowcool

Copy link
Copy Markdown
Collaborator

Problem

The generic examples expose a public fallback access point and allow the remote package's OTA password substitution to remain unset. The ESPHome schema accepts the unresolved substitution as a literal, so the missing credential is not rejected at configuration load time.

Change

  • Remove the public AP fallback from the generic core; a device must provide its Wi-Fi credentials.
  • Remove the empty OTA password default and require each device example to provide an explicit secret.
  • Add a compile-time guard that rejects an empty or unresolved ota_password.
  • Document the migration and keep the standalone example independent from the fork inventory.

This contribution contains no fleet inventory, Home Assistant state, NAS path, or device-specific value. The guard performs no runtime action.

Validation

  • 75 isolated tests, including the OTA credential contract.
  • ESPHome 2026.10 isolated MQTT firmware build with a synthetic OTA secret.
  • Synthetic C++ checks prove explicit values pass and empty/unresolved values fail.
  • Public API and MQTT examples validate with synthetic local secrets.

Refs #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant