Fix FlexBox pref/min size computation for wrapping#91
Merged
FlorianKirmaier merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
…apping computePrefHeight(width) and computePrefWidth(height) ignored their argument, so wrapping FlexBoxes always reported single-row/column sizes. Added getContentBias() so JavaFX parent layouts pass the correct dimension, and fixed min size methods to simulate wrap line-breaking as well. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computePrefHeight(width)andcomputePrefWidth(height)to simulate wrap line-breaking when the available dimension is known, instead of always reporting single-row/column sizesgetContentBias()override so JavaFX parent layouts pass the actual width/height to size computationscomputeMinHeight(width)andcomputeMinWidth(height)with the same wrapping logicTest plan
FlexBoxPrefSizeTesttests pass (23 tests)🤖 Generated with Claude Code