Mock wl-copy in the empty-text clipboard test - #152
Merged
Merged
Conversation
It was the one clipboard test without MockClipboardTool, so on a Wayland desktop it ran the real wl-copy: the developer's clipboard was replaced, and wl-copy's forked background server inherited the test binary's stdout, so `cargo test -p voxctrl-routing | tail` hung after every test passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_clipboard_target_failure_empty_textwas the one clipboard test withoutMockClipboardTool. On a Wayland desktop it ran the realwl-copy, which caused two problems:wl-copyforks a background server to keep serving the clipboard, and that server kept the test binary's stdout open. Socargo test -p voxctrl-routing | tailhung forever after every test had passed.The test now installs the same mock the other two clipboard tests use.
Test plan
timeout 120 sh -c 'cargo test -p voxctrl-routing | tail -3'now exits 0; before the fix it timed out🤖 Generated with Claude Code