refactor: extract state guard checks into require_state macro#112
Open
HushLuxe wants to merge 1 commit into
Open
refactor: extract state guard checks into require_state macro#112HushLuxe wants to merge 1 commit into
HushLuxe wants to merge 1 commit into
Conversation
|
@HushLuxe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
please resolve conflict nd try again |
Contributor
|
please resolve conflict and try again |
Replace duplicate assert!(escrow.state == EscrowState::X) patterns with a reusable require_state! macro that auto-generates descriptive error messages. Also restore missing state field on EscrowData (lost during upstream merge) and remove duplicate ContractError enum. Closes JSE-ORG#83
HushLuxe
force-pushed
the
fix/83-extract-state-guard-macro
branch
from
b9892e1 to
a183f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace duplicate assert!(escrow.state == EscrowState::X) patterns with a reusable require_state! macro that auto-generates descriptive error messages.
Closes #83