Refactor event emitters to use consistent Symbol topic encoding#115
Open
Ryjen1 wants to merge 1 commit into
Open
Refactor event emitters to use consistent Symbol topic encoding#115Ryjen1 wants to merge 1 commit into
Ryjen1 wants to merge 1 commit into
Conversation
Closes JSE-ORG#79. Standardize event topic definitions and encoding across all processing paths. Changes: - Define all 7 event topic names as centralized &str constants (TOPIC_CREATE_ESCROW, TOPIC_FUND_ESCROW, TOPIC_CONFIRM_DELIVERY, TOPIC_RAISE_DISPUTE, TOPIC_RESOLVE_DISPUTE, TOPIC_CANCEL_ESCROW, TOPIC_AUTO_RELEASE) in one place for DRY consistency - Replace inline string literals with Symbol::new(&env, TOPIC_*) at every publish site, encoding all topics as ScVal::Symbol instead of ScVal::String for uniform XDR representation - All topics follow lower_snake_case naming convention Event parsers can now reliably match on ScVal::Symbol for every event category. Topic names are defined once as constants, making renaming or auditing trivial. Also fix pre-existing test compilation errors: missing closing brace, missing fee_bps args, and incorrect setup_env destructuring.
|
@Ryjen1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&strconstants in one placeSymbol::new(&env, TOPIC_*)at every publish siteScVal::Symbol(wasScVal::String) for uniform XDR representationAcceptance Criteria Met
TOPIC_CREATE_ESCROW,TOPIC_FUND_ESCROW,TOPIC_CONFIRM_DELIVERY,TOPIC_RAISE_DISPUTE,TOPIC_RESOLVE_DISPUTE,TOPIC_CANCEL_ESCROW,TOPIC_AUTO_RELEASE)ScVal::Symbolinstead of a mix ofScVal::String, enabling consistent parsingChanges (
lib.rs)Symbolimport and 7 topic name constants at module levelenv.events().publish(("literal",), ...)calls withenv.events().publish((Symbol::new(&env, TOPIC_*),), ...)Closes #79