feat: implement initialize() per issue #14#142
Closed
hartz0 wants to merge 2 commits into
Closed
Conversation
- Return ContractError::AlreadyInitialized instead of panic - Validate fee_bps <= MAX_FEE_BPS (FeeExceedsMax on failure) - Require admin auth before writing state - Set EscrowCounter to 0; create_escrow pre-increments so first ID = 1 - Emit ContractInitialized event with admin, fee_bps, fee_collector, timestamp - Add ContractInitialized event struct - Remove duplicate type/function definitions from lib.rs - Update all 49 test call sites to new signature (admin, fee_bps, fee_collector) - Add tracking_id param to mark_shipped to match test expectations
|
@hartz0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Please resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14
Implements the one-time initialize(admin, fee_bps, fee_collector) contract constructor per
issue 14. Returns ContractError::AlreadyInitialized on repeat calls, validates fee_bps
against the 300 bps cap, requires admin auth, sets the escrow counter to 0, and emits a
ContractInitialized event. Also removes pre-existing duplicate type definitions that would
have prevented compilation.