fix(public-stats): redact sparse accuracy trend counts#4979
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 45f727f | Commit Preview URL Branch Preview URL |
Jul 11 2026, 01:12 PM |
e0f5903 to
45f727f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4979 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 468 468
Lines 39616 39616
Branches 14456 14456
=======================================
Hits 37314 37314
Misses 1646 1646
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-12 01:10:06 UTC
⏸️ Suggested Action - Manual Review
Review summary Blockers
Nits — 5 non-blocking
Concerns raised — review before merging
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
The rebase's own worker-configuration.d.ts regeneration (done to resolve a merge conflict) picked up 176 lines of unrelated drift from this local machine's wrangler/workerd cache being out of sync with whatever last regenerated main's copy correctly. This PR has no legitimate reason to touch this generated file at all -- copy main's exact, already-correct content instead of regenerating it locally.


Motivation
merged,closed, andreversedcounts that allow unauthenticated callers to reconstruct a suppressedaccuracyPctfor sparse weeks.Description
merged,closed, andreversedasnullwhen(merged+closed) < MIN_ACCURACY_TREND_SAMPLE, implemented viapublicBucketOf(...)and applied inbuildPublicAccuracyTrend(src/services/public-accuracy-trend.ts).PublicAccuracyTrendWeekfields nullable (merged,closed,reversed) and update the openapi/schema to accept nullable counts (src/openapi/schemas.tsand regeneratedapps/gittensory-ui/public/openapi.json).test/unit/public-accuracy-trend.test.ts,test/integration/public-stats-route.test.ts).apps/gittensory-ui/public/openapi.json,worker-configuration.d.ts).Testing
npm run ui:openapisuccessfully to regenerate the UI OpenAPI artifact. (passed)npm --workspace @jsonbored/gittensory-engine run buildto ensure package parity. (passed)npx vitest run test/unit/public-accuracy-trend.test.ts test/integration/public-stats-route.test.tsand all tests in those files passed. (passed)npm run test:ciand observed a failure during the unsharded coverage phase where several pre-existing queue sweep tests timed out intest/unit/queue.test.ts, causing the overall gate to fail. (failed during fulltest:cicoverage phase)npm audit --audit-level=moderatebut the registry audit endpoint returned403 Forbidden, so dependency audit could not complete. (audit unavailable)Codex Task