fix(review): keep screenshots allowlist-bound

[JSONbored]

Motivation

• A prior refactor added screenshots to the converged features: resolver using the default standard precedence, which let a repo's .gittensory.yml features.screenshots: true bypass the operator GITTENSORY_REVIEW_REPOS allowlist and trigger costly server-side browser captures.

Description

• Keep screenshots under allowlistRequired by adding screenshots: "allowlistRequired" to FEATURE_MODE in src/review/feature-activation.ts so a manifest cannot force it ON outside the operator allowlist.
• Update the feature-mode documentation/comments in src/review/feature-activation.ts to call out that screenshots launches browser rendering and stores/publicly-embedded images, and therefore must remain allowlist-bound.
• Add regression tests in test/unit/feature-activation.test.ts and test/unit/visual-wire.test.ts that assert an unallowlisted repo with features.screenshots: true cannot activate screenshots and that allowlisted repos still default ON or can opt out.
• Regenerate Cloudflare worker runtime types (worker-configuration.d.ts) after the local cf-typegen drift check reported stale generated output.

Testing

• Ran the focused unit suites with npx vitest run test/unit/feature-activation.test.ts test/unit/visual-wire.test.ts, and both test files passed (all tests succeeded).
• Ran npm run typecheck and npm run cf-typegen:check (and regenerated worker-configuration.d.ts), both succeeded locally.
• Attempted the full gate via npm run test:ci; the run exercised the suite but stopped on unrelated, pre-existing failures in test/unit/queue-5.test.ts (these are unrelated to this change and prevented a full green test:ci).
• npm audit --audit-level=moderate could not complete due to the registry endpoint returning 403 Forbidden in this environment.

---

Codex Task

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (a21a8ad) to head (2fd6a31).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4990   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         468      468           
  Lines       39608    39608           
  Branches    14448    14448           
=======================================
  Hits        37306    37306           
  Misses       1646     1646           
  Partials      656      656           

Flag	Coverage Δ
shard-1	46.47% <ø> (-0.01%)	⬇️
shard-2	33.58% <ø> (-0.27%)	⬇️
shard-3	31.39% <ø> (-0.82%)	⬇️
shard-4	32.68% <ø> (+0.72%)	⬆️
shard-5	33.21% <ø> (-0.10%)	⬇️
shard-6	45.18% <ø> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/review/feature-activation.ts	100.00% <ø> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gittensory-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-12 01:10:35 UTC}

3 files · 1 AI reviewer · 2 blockers · readiness 93/100 · CI green · unstable

⏸️ Suggested Action - Manual Review

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This closes a real allowlist-bypass: `screenshots` was resolving under the default `"standard"` mode, letting a repo's own `.gittensory.yml` force browser-based screenshot capture ON even when the repo isn't in `GITTENSORY_REVIEW_REPOS`. Adding `screenshots: "allowlistRequired"` to `FEATURE_MODE` in feature-activation.ts:105 routes it through the same `allowlisted && override !== false` arithmetic already used for `grounding`, which is the correct fix at the source (resolveFeatureActivation), not a symptom patch. The doc comments and both test files (feature-activation.test.ts, visual-wire.test.ts) are updated consistently, and the new/changed assertions exercise the real `resolveConvergedFeature` call path — not a fabricated state. The worker-configuration.d.ts diff is pure generated-artifact churn from a `cf-typegen` regen, unrelated to the fix but explained and low-risk.

Nits — 4 non-blocking

• The PR description doesn't cite an open issue this fix closes — only historical refs (fix(review): features.safety is per-repo disableable via .gittensory.yml even when the operator enabled it globally #2269, Unify per-feature *-wire.ts activation behind one shared resolver #4616) for context; per this repo's convention, contributor PRs should link the issue they close even for a bug/security fix like this one.
• Bundling the large generated worker-configuration.d.ts regen with the behavioral fix makes the diff noisier to scan even though it carries no independent risk — consider splitting generated-artifact updates into their own PR/commit going forward.
• Consider a short changelog/release-note line calling out that screenshots was previously allowlist-bypassable, since operators who noticed unexpected browser-capture costs will want to know this was the root cause.
• The doc comment at feature-activation.ts:47-60 now lists three `allowlistRequired` features' worth of rationale inline — as more features accumulate this shape, consider a per-feature rationale map instead of prose to keep it scannable.

Concerns raised — review before merging

• No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
• Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Signal	Result	Evidence
Code review	❌ 2 blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 45 registered-repo PR(s), 37 merged, 415 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 45 PR(s), 415 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.
Improvement	✅ Minor	risk: clean · value: minor — Code changes are accompanied by test evidence.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
• Official Gittensor activity: 45 PR(s), 415 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
• @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review