fix(selfhost): retry the container health-status check, not just /ready#5090
Merged
Conversation
…dy (#5089) #5085 fixed the /ready HTTP probe to retry instead of single-attempt- failing, then immediately surfaced this second, previously-masked instance of the same bug on the very next deploy: the Docker container health-status check right below it is also a single, non-retrying check, and caught the container in Docker's own transient "starting" state (its healthcheck re-probes /ready on an independent interval/start_period schedule, so it can still be "starting" even after /ready itself already answered 2xx). Retries only through "starting" -- any other non-healthy/running status (unhealthy, exited, restarting, ...) fails immediately rather than burning the full retry budget on something that will not resolve on its own. Verified against both paths: starting -> healthy resolves via retry, and an immediate unhealthy status fails fast without waiting.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5090 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 470 470
Lines 39722 39722
Branches 14493 14493
=======================================
Hits 37421 37421
Misses 1645 1645
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5089
Scope
Validation
Safety