Skip to content

fix(ci): build the engine package before Typecheck, not just before coverage #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 11, 2026
Merged

fix(ci): build the engine package before Typecheck, not just before coverage #5093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,18 @@ jobs:
env:
NODE_OPTIONS: ""
run: node scripts/validate-observability-configs.mjs
# Runs ahead of Typecheck AND "Test with coverage" (#ci-engine-build-order): src/mcp/find-opportunities.ts
# (root backend, since #2281/#3985) imports packages/gittensory-miner/lib/opportunity-fanout.js --
# committed, pre-built JS -- which itself imports @jsonbored/gittensory-engine. That package's dist/ is
# gitignored and only exists after this build step, so ANY backend typecheck or test run needs it built
# first, not just a PR that touches packages/gittensory-engine/** directly (this step's original, too-
# narrow trigger). Originally ran after coverage (broke test:coverage on PRs that didn't touch the
# engine) and after Typecheck (broke a real, non-vi.mock `import type` from the package specifier with
# TS2307 in CI while passing locally against a stale leftover dist/ -- first hit by PR #5082). Now ahead
# of both.
- name: Build engine package
if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' || needs.changes.outputs.engine == 'true' }}
run: npm run build --workspace @jsonbored/gittensory-engine
# .tsbuildinfo mutates every run (tsc's own incremental state), unlike node_modules above which is
# immutable per lockfile -- so this needs the run_id-suffixed-key + restore-keys-prefix pattern (always
# creates a new cache entry to save into, restore falls back to the most recent matching prefix) rather
Expand All @@ -294,16 +306,6 @@ jobs:
with:
path: .tsbuildinfo
key: tsbuildinfo-${{ hashFiles('tsconfig.json', 'package-lock.json') }}-${{ github.run_id }}
# Moved ahead of "Test with coverage" (#ci-engine-build-order): src/mcp/find-opportunities.ts (root
# backend, since #2281/#3985) imports packages/gittensory-miner/lib/opportunity-fanout.js -- committed,
# pre-built JS -- which itself imports @jsonbored/gittensory-engine. That package's dist/ is gitignored
# and only exists after this build step, so ANY backend test run needs it built first, not just a PR
# that happens to touch packages/gittensory-engine/** directly (this step's original, too-narrow
# trigger, back when the two packages were still independent). Running late (its original position,
# after coverage) meant test:coverage failed to resolve the package on every PR that didn't touch it.
- name: Build engine package
if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' || needs.changes.outputs.engine == 'true' }}
run: npm run build --workspace @jsonbored/gittensory-engine
- name: Worker runtime tests
if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' }}
run: npm run test:workers
Expand Down