fix(ci): build the engine package before the self-host Postgres integration test#5122
Merged
Merged
Conversation
…ration test The Postgres integration test's import graph now reaches @jsonbored/gittensory-engine transitively (#5117 moved local-write action specs there; src/mcp/local-write-tools.ts re-exports them from the engine package). That package's dist/ is gitignored and only exists after an explicit build step, which this workflow never had -- same #ci-engine-build-order class of bug ci.yml's "Build engine package" step already exists to prevent, just missed here. Reproduced locally (removed dist/, confirmed the exact "Failed to resolve entry for package" error; rebuilt, confirmed it resolves cleanly) before landing the fix.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5122 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 471 471
Lines 39821 39821
Branches 14533 14533
=======================================
Hits 37560 37560
Misses 1583 1583
Partials 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/selfhost.yml's "build + boot smoke test" job runs the Postgres integration test (test/integration/selfhost-pg.test.ts) right afternpm ci --ignore-scripts, with no step building@jsonbored/gittensory-engine'sdist/output first.processJobfromsrc/queue/processors.ts, which importssrc/mcp/local-write-tools.ts, which (since refactor(engine): move local-write action specs into the shared engine package #5117 moved local-write action specs into the shared engine package) re-exports from@jsonbored/gittensory-engine. The package'sdist/is gitignored and only exists afternpm run build --workspace @jsonbored/gittensory-engine— this workflow never had that step because it never needed it before.#ci-engine-build-orderbug classci.yml's own "Build engine package" step exists to prevent (see its comment, first hit by PR fix(miner-governor): wire buildHouseRulesPreToolUseHook into a real driver-construction call site #5082, fixed by fix(ci): build the engine package before Typecheck, not just before coverage #5093 for Typecheck/coverage) — just missed in this separate workflow.docker-compose.yml, one of this workflow's trigger paths — it's the first PR to actually exerciseselfhost.ymlsince refactor(engine): move local-write action specs into the shared engine package #5117 landed, surfacing a break that's been latent onmainsince then. Confirmed this is not required-check-blocking (onlyvalidate+Superagent Security Scanare required) and not caused by that PR's own diff, so fixing it here as its own focused change instead.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
npm run actionlint— clean.packages/gittensory-engine/dist, rannpx vitest run test/integration/selfhost-pg.test.ts, got the identicalFailed to resolve entry for package "@jsonbored/gittensory-engine"error atsrc/review/fix-handoff-render.ts:14:1/src/mcp/local-write-tools.ts:8:1.npm run build --workspace @jsonbored/gittensory-engine(the exact command now added to the workflow), re-ran the test: resolves cleanly, 6 tests skip (noPG_TEST_URLlocally — expected, matches the test file's own documented local-run instructions).Safety