Repository navigation
chore(deps): bump oauthlib from 3.3.1 to 4.0.0 - #17
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.3.1 to 4.0.0. - [Release notes](https://github.com/oauthlib/oauthlib/releases) - [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst) - [Commits](oauthlib/oauthlib@v3.3.1...v4.0.0) --- updated-dependencies: - dependency-name: oauthlib dependency-version: 4.0.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| [[package]] | ||
| name = "oauthlib" | ||
| version = "3.3.1" | ||
| version = "4.0.0" |
There was a problem hiding this comment.
🔥 The Roast: A major bump (3.3.1 → 4.0.0) that upstream announces with two breaking changes, and pr-agent never imports oauthlib itself — it just inherits it through atlassian-python-api and msrest. The Atlassian path at least screams: from atlassian.bitbucket import Cloud (pr_agent/git_providers/bitbucket_provider.py:9) is a module-level import the unit suite already exercises, so a client-API break there breaks CI loudly. The Azure path whispers instead: pr_agent/git_providers/azuredevops_provider.py:93 wraps the entire optional stack in a blanket except ImportError and quietly flips AZURE_DEVOPS_AVAILABLE = False, and nothing in the suite asserts that flag stays True or that msrest.authentication still imports. So if oauthlib 4.0.0 ever stubs a toe in requests-oauthlib 2.0.0's expectations, the Azure DevOps provider evaporates in production while CI applauds a green checkmark.
🩹 The Fix: Add a tiny guard test asserting the optional Azure stack still imports (e.g. import msrest.authentication, and AZURE_DEVOPS_AVAILABLE is True when msrest is installed), so the next oauthlib major bump fails loudly in CI instead of silently disabling a provider.
📏 Severity: suggestion
Code Review Roast 🔥Verdict: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The two upstream breaking changes (JSONP removal on the revocation endpoint, 💀 Worst part: The one path that could break quietly — 📊 Overall: Like swapping the battery in a smoke alarm — the part is right, the alarm still works, but only for the house that has a test button. Files Reviewed (1 files)
Fix these issues in Kilo Cloud Reviewed by free · Input: 104.9K · Output: 19.5K · Cached: 904.9K |
Bumps oauthlib from 3.3.1 to 4.0.0.
Release notes
Sourced from oauthlib's releases.
Changelog
Sourced from oauthlib's changelog.
Commits
145a9a4Release 4.0.0: clarify changelog breaking changes and reformat entriesc8344d6Update CHANGELOG.rste172830Release 4.0.0: bump version to 4.0.0 and update changelog40b0ab5Merge pull request #963 from oauthlib/ft/pkcecode1b68ceaMerge pull request #920 from hekhuisk/validate-client-authenticationc951a1dOrganized validate_client functions for all grant to avoid mistake in grnat i...74664d3Improve PKCE code comparison9859b05Merge pull request #950 from oauthlib/feature/3.4.0-maintainer-agent9bf9b97Merge branch 'master' into feature/3.4.0-maintainer-agent1ba7429Clarify agent instructionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Bumps the indirect
oauthlibdependency from 3.3.1 to 4.0.0 inuv.lock. This major release includes two breaking changes in the OAuth2.0 provider worth checking against the project's code.Breaking Changes
enable_jsonpandcallbackparameters no longer exist.grant_typeis now checked first: missinggrant_typereturns400 invalid_requestinstead of401 invalid_client.Written for commit 94656c2. Summary will update on new commits.