Repository navigation
reftest-plugin: refresh stale description - #25
Merged
Merged
Conversation
The plugin description was written before step 11 landed and described the upcoming change rather than the current behaviour. Now that step 11 is merged, reftest_plugin.reconcile actually writes the sentinel — the description should reflect what the plugin does today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reftest plugin's manifest still said Step 11 turns this into a sentinel-writing reconciler — true at the time of #24, stale now that #24 is merged. Updating it to describe what the plugin does today: write a sentinel, used by the kernel acceptance test.
No code change.
Test plan
manifest.tomlparses (loader didn't change).