Skip to content

Show a fetched site icon in the icon dialog straight away - #105

Merged
Ghosts merged 1 commit into
masterfrom
project-icon-preview
Nov 16, 2026
Merged

Ghosts merged 1 commit into
masterfrom
project-icon-preview

Conversation

@Ghosts

@Ghosts Ghosts commented Nov 16, 2026

Copy link
Copy Markdown
Member

The icon dialog rendered the project object its caller captured when it opened, so an icon fetched from a website was saved but the preview and Done button only appeared on the next open. The dialog now reads the saved project from the store.

Checked with lint, typecheck and knip. Not yet confirmed in the running app.

@Ghosts
Ghosts merged commit 12c816a into master Nov 16, 2026
11 of 12 checks passed
@Ghosts
Ghosts deleted the project-icon-preview branch November 16, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant