fix(tests): use dynamic patch count assertion in test_verl080_migration - #63
Open
lgc2013 wants to merge 1 commit into
Open
fix(tests): use dynamic patch count assertion in test_verl080_migration#63lgc2013 wants to merge 1 commit into
lgc2013 wants to merge 1 commit into
Conversation
The 3 auto-activation tests hardcoded '7 patches' but the actual count is environment-dependent: 7 with only verl080_fsdp, or 14 when both verl080_fsdp and verl080_mcore0161_ms0160 patch sets are installed. Add _expected_patch_count() helper that checks for megatron.core and mindspeed availability to compute the correct expected count.
lgc2013
force-pushed
the
fix/test-patch-count-assertion
branch
from
August 13, 2026 09:50
4a8278e to
ed26134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 3 auto-activation tests in
test_verl080_migration.pyhardcoded the expected patch count as"PatchHandle (ACTIVE, 7 patches):", but the actual count is environment-dependent:verl080_fsdppatch set is installed (verl only)verl080_fsdp+verl080_mcore0161_ms0160are installed (verl + Megatron Core + MindSpeed)This caused 3 test failures in environments with the full training stack installed.
Fix
Added
_expected_patch_count()helper that dynamically computes the expected patch count by checking whethermegatron.coreandmindspeedare importable:Updated the 3 test assertions to use this helper instead of a hardcoded number.
Tests
All 30 tests in
test_verl080_migration.pynow pass (previously 3 failed).