Allow passing models directly as parameters to odes.run()#46
Merged
Conversation
This change also begins to generalize to _BaseSINDy in order to support the Simultaneous/Single-Step/Joint SINDy of our dreams. However, that exposes up a lot of type holes in our heirarchy (perhaps a good thing long term).
It had previously been accepted that, when training SINDy models on multiple trajectories, you could just use a single trajectory for t. This works, but allows too many ways of doing the same thing (bad PEP 20).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because mitosis could only handle a few containers as parameters (e.g. nested dictionaries), all of these experiments were written with nested dictionaries as the parameter type. Now that mitosis allows parameters to be custom container classes, we should modify
odes.run()(and eventually, gridsearch) to allow them: It makes updating parameter names much easier due to IDE's static code analysis.