Conversation
|
Restarted the CI because it was hanging on the system requirements. |
code/drasil-printing/package.yaml
Outdated
| - drasil-database | ||
| - drasil-lang | ||
| - drasil-metadata | ||
| - drasil-theory | ||
| - drasil-utils | ||
| - split | ||
|
|
||
| ghc-options: | ||
| - -Wall | ||
| - -Wredundant-constraints | ||
|
|
||
| library: | ||
| source-dirs: lib | ||
| exposed-modules: | ||
| - Language.Drasil.Config | ||
| - Language.Drasil.Plain.Print | ||
| - Language.Drasil.Printing.AST | ||
| - Language.Drasil.Printing.Citation | ||
| - Language.Drasil.Printing.Helpers | ||
| - Language.Drasil.Printing.Import | ||
| - Language.Drasil.Printing.Import.CodeExpr | ||
| - Language.Drasil.Printing.Import.Document | ||
| - Language.Drasil.Printing.Import.Expr | ||
| - Language.Drasil.Printing.Import.Helpers | ||
| - Language.Drasil.Printing.Import.Literal | ||
| - Language.Drasil.Printing.Import.ModelExpr | ||
| - Language.Drasil.Printing.Import.Sentence | ||
| - Language.Drasil.Printing.Import.Space | ||
| - Language.Drasil.Printing.Import.Symbol | ||
| - Language.Drasil.Printing.LayoutObj | ||
| - Language.Drasil.Printing.PrintingInformation |
There was a problem hiding this comment.
Should drasil-printing be doing this much? I thought that these modules were meant to be kept in drasil-printers?
There was a problem hiding this comment.
What I think this does, in part, is to separate the parts that are about specific output formats (kept in drasil-printers) from "the rest". So that drasil-printing becomes the 'awfully messy' package and drasil-printers may be regarded as fairly clear.
Of course, the new drasil-printing should not have so many exposed modules! It would be best to see how few of these modules need to be exposed.
There was a problem hiding this comment.
Ah, ok. In that case, should LayoutObj, PrintingInformation, and Language.Drasil.Printing.AST stay in drasil-printers?
There was a problem hiding this comment.
Once @JoeZZG trims down the exposed modules, we'll see. I guess one could see now, by staring at the dependency graph of the unsplit version.
code/drasil-printing/package.yaml
Outdated
| - drasil-database | ||
| - drasil-lang | ||
| - drasil-metadata | ||
| - drasil-theory | ||
| - drasil-utils | ||
| - split | ||
|
|
||
| ghc-options: | ||
| - -Wall | ||
| - -Wredundant-constraints | ||
|
|
||
| library: | ||
| source-dirs: lib | ||
| exposed-modules: | ||
| - Language.Drasil.Config | ||
| - Language.Drasil.Plain.Print | ||
| - Language.Drasil.Printing.AST | ||
| - Language.Drasil.Printing.Citation | ||
| - Language.Drasil.Printing.Helpers | ||
| - Language.Drasil.Printing.Import | ||
| - Language.Drasil.Printing.Import.CodeExpr | ||
| - Language.Drasil.Printing.Import.Document | ||
| - Language.Drasil.Printing.Import.Expr | ||
| - Language.Drasil.Printing.Import.Helpers | ||
| - Language.Drasil.Printing.Import.Literal | ||
| - Language.Drasil.Printing.Import.ModelExpr | ||
| - Language.Drasil.Printing.Import.Sentence | ||
| - Language.Drasil.Printing.Import.Space | ||
| - Language.Drasil.Printing.Import.Symbol | ||
| - Language.Drasil.Printing.LayoutObj | ||
| - Language.Drasil.Printing.PrintingInformation |
There was a problem hiding this comment.
What I think this does, in part, is to separate the parts that are about specific output formats (kept in drasil-printers) from "the rest". So that drasil-printing becomes the 'awfully messy' package and drasil-printers may be regarded as fairly clear.
Of course, the new drasil-printing should not have so many exposed modules! It would be best to see how few of these modules need to be exposed.
JacquesCarette
left a comment
There was a problem hiding this comment.
Better. But now we need to know why the others must be exposed.
#4831
drasil-printingis a new package, which contains the shared printing infrasturecture:Printing.AST,Printing.LayoutObj,Printing.PrintingInformation,Printing.Import.*(all expression/document converters),Printing.Citation,Printing.Helpers,Plain.Print,Configdrasil-printersis now smaller and only contains format-specific printers (HTML, TeX, JSON, Markdown and Debug), and depends ondrasil-printingNo other things changed