Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideAdds comprehensive documentation for Metis architecture, API, and engine configuration, wires in a Nextflow engine container to the local Docker Compose stack, and restructures the docs navigation to surface the new guides and references. Sequence diagram for workflow run lifecycle via API (sequence)sequenceDiagram
actor Client
participant API as metis-api
participant PG as PostgreSQL
participant NATS as NATS
participant Engine as metis-engine-nextflow
participant WF as Nextflow_process
Client->>API: POST /runs {RunRequest}
API->>API: Validate against engine.yaml
API->>PG: INSERT run (state=QUEUED)
API->>NATS: publish run.submit.Nextflow
API-->>Client: 200 {run_id}
NATS-->>Engine: run.submit.Nextflow message
Engine->>PG: UPDATE run state=INITIALIZING
Engine->>NATS: publish run.state.run_id INITIALIZING
Engine->>Engine: Build CLI from commandTemplate
Engine->>Engine: Create workdir layout
Engine->>WF: Spawn Nextflow subprocess
Engine->>PG: UPDATE run state=RUNNING
Engine->>NATS: publish run.state.run_id RUNNING
loop For each stdout/stderr line
WF-->>Engine: log line
Engine->>PG: INSERT log_lines row
end
WF-->>Engine: process exit (code)
alt exit code 0
Engine->>PG: UPDATE run state=COMPLETE
Engine->>NATS: publish run.state.run_id COMPLETE
else nonzero exit code
Engine->>PG: UPDATE run state=EXECUTOR_ERROR
Engine->>NATS: publish run.state.run_id EXECUTOR_ERROR
end
Client->>API: GET /runs/{id}/status or /logs
API->>PG: SELECT state, logs
API-->>Client: JSON response
Client->>API: GET /runs/{id}/status/stream
API->>NATS: subscribe run.state.run_id
NATS-->>API: state events
API-->>Client: SSE state events
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The docs and configuration alternate between
engine.yamlandengine-config.yaml(and different paths), which could be confusing; consider standardizing on a single filename/path and updating both the docs anddocker-compose.yamlto match. - Several docs hardcode specific versions and paths (e.g.,
workflow_engine_version: "25.10.4",workflow_url: "/root/workflows/main.nf",postgres:18-alpine); it may be clearer to either reference the actual versions/paths used indocker-compose.yamlor explicitly label these as examples tied to the default local setup.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The docs and configuration alternate between `engine.yaml` and `engine-config.yaml` (and different paths), which could be confusing; consider standardizing on a single filename/path and updating both the docs and `docker-compose.yaml` to match.
- Several docs hardcode specific versions and paths (e.g., `workflow_engine_version: "25.10.4"`, `workflow_url: "/root/workflows/main.nf"`, `postgres:18-alpine`); it may be clearer to either reference the actual versions/paths used in `docker-compose.yaml` or explicitly label these as examples tied to the default local setup.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
Author
|
@sourcery-ai title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comments
Summary by Sourcery
Document engine-centric architecture and configuration, and wire up the default Nextflow engine in local deployments.
New Features:
Enhancements:
Deployment:
Documentation: