Skip to content

Prepare external audit checklist for smart contracts#1296

Open
TUPM96 wants to merge 1 commit into
Jagadeeshftw:masterfrom
TUPM96:codex/external-audit-checklist-1290
Open

Prepare external audit checklist for smart contracts#1296
TUPM96 wants to merge 1 commit into
Jagadeeshftw:masterfrom
TUPM96:codex/external-audit-checklist-1290

Conversation

@TUPM96
Copy link
Copy Markdown

@TUPM96 TUPM96 commented May 25, 2026

Closes #1290

Summary

  • Added docs/security/external-audit-checklist.md covering the scoped Grainlify smart contracts.
  • Inventoried program-escrow, bounty_escrow, and grainlify-core entrypoints with expected access controls and associated error codes.
  • Added threat model coverage for reentrancy, oracle-like inputs, fee-drain paths, role drift, storage pagination, and upgrade safety.
  • Added a small program-escrow doc pointer and checklist coverage tests so required audit sections do not drift silently.
  • Repaired a malformed rate-limit auth test wrapper so src/test.rs can parse past that pre-existing block.

Validation

  • git diff --check origin/master..HEAD passes.
  • cargo test -p program-escrow is currently blocked by pre-existing compile failures outside this checklist patch, including Soroban symbol/function name length limits, duplicate BatchError discriminants, unresolved ContractError/Error references, and broken test_pagination imports/attributes.
  • cargo fmt --check is also blocked by broad pre-existing formatting drift across program-escrow files.

Security notes

  • This PR does not disclose or exploit any private vulnerability.
  • The checklist tracks the known pre-audit gaps from the issue, including incomplete Draft-state handling and missing/broken test wiring.

Copilot AI review requested due to automatic review settings May 25, 2026 09:54
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

@TUPM96 is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare external security audit checklist and remediation tracking for grainlify contracts

2 participants